Skip to content

Conversation

skyoxZ
Copy link
Contributor

@skyoxZ skyoxZ commented Dec 1, 2023

@skyoxZ skyoxZ requested a review from a team as a code owner December 1, 2023 04:37
@ghost ghost added community-contribution Indicates that the PR has been added by a community member area-System.Numerics labels Dec 1, 2023
@ghost
Copy link

ghost commented Dec 1, 2023

Tagging subscribers to this area: @dotnet/area-system-numerics
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix dotnet/runtime#94500

Author: skyoxZ
Assignees: -
Labels:

area-System.Numerics, community-contribution

Milestone: -

Copy link

Learn Build status updates of commit c23984f:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Numerics/INumberBase`1.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @skyoxZ

I'll :shipit: now.

Co-authored-by: Tanner Gooding <tagoo@outlook.com>
@BillWagner BillWagner enabled auto-merge (squash) December 1, 2023 18:31
Copy link

Learn Build status updates of commit e1514d2:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Numerics/INumberBase`1.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@BillWagner BillWagner merged commit 0b83b36 into dotnet:main Dec 1, 2023
@skyoxZ
Copy link
Contributor Author

skyoxZ commented Dec 2, 2023

@tannergooding @BillWagner Thanks. dotnet/runtime#95495 updated for your suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-System.Numerics community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs and XML comments for Min/MaxMagnitude are incorrect

3 participants